Repository navigation
Un-quarantine the qualified-spelling witness: the repair merged, so the floor measures it again - #9065
Merged
Conversation
…he floor measures it again #9044 landed the repair for the cost defect this witness exposed, so the quarantine row's dissolution condition is met on its first half. The row said it dissolves when the defect 'is root-caused and repaired, at which point the arm measures under gunbc_ci_fast_lane_eval_budget_ms' -- and deliberately NOT on a cost envelope, because an envelope large enough to admit 1.22GB and 57s would have admitted the defect rather than measured it. THE SECOND HALF IS UNMEASURED, AND THIS PR IS THE MEASUREMENT. The 412x figure (44886ms -> 109ms) comes from local instrumented probes against varied source roots, not from the floor: the witness has been excluded since before the repair existed, so no floor run has ever executed the repaired path. Restoring it is the only way to take that reading, and a red here is a legitimate outcome rather than a failure of this change -- it would mean the floor's subject differs from the probe's in a way that matters, which is worth knowing before the row disappears. Two things stay open on purpose and must not be read as settled by a green: The 1.22GB RSS was never attributed to the repaired term. Three agreeing wall figures and a plausible shape is consistent-with, not measured. If the memory line survives this run, that is a SECOND defect and it should stay visible rather than be credited to #9044. And a residue did not move: the bare arm measured 12967ms before the repair and 12881ms after, on the dag-only root set. It was never part of the qualified-annotation asymmetry -- a separate cold-index term for a root set that does not match the process's warm index. Restores the file to dag/test/claim/, its module path, and the provider fixture's pointer, which named the long/ home. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9044 landed the repair for the cost defect this witness exposed. The quarantine row's dissolution is met on its first half — it dissolves when the defect "is root-caused and repaired, at which point the arm measures under
gunbc_ci_fast_lane_eval_budget_ms" — and deliberately not on a cost envelope, because an envelope large enough to admit 1.22GB and 57s would have admitted the defect rather than measured it.This PR is the measurement, and a red is a legitimate outcome
The second half of that condition is unmeasured. The 412x figure (44886ms → 109ms) comes from local instrumented probes against varied source roots, not from the floor. The witness has been excluded since before the repair existed, so no floor run has ever executed the repaired path. Restoring it is the only way to take that reading.
If this goes red, that is information rather than a failure of this change: it would mean the floor's subject differs from the probe's in a way that matters, which is worth knowing before the row disappears. Reviewers should not treat a red here as a reason to restore the quarantine — it is a reason to re-open the defect.
Two things stay open and are not settled by a green
The 1.22GB RSS was never attributed to the repaired term. Three agreeing wall figures plus a plausible shape is consistent-with, not measured. If the memory line survives this run, that is a second defect and it should stay visible rather than be credited to #9044.
A residue did not move. The bare arm measured 12967ms before the repair and 12881ms after, on the dag-only root set — so it was never part of the qualified-annotation asymmetry. It is a separate cold-index term for a root set that does not match the process's warm index.
Scope
Restores the file to
dag/test/claim/, restores its module path, deletes theWitnessExclusionRow, and repairs the provider fixture's prose pointer, which named thelong/home. No change to what either arm asserts.